Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: remove AWS deployment #603

Merged
merged 4 commits into from
Jun 9, 2022
Merged

Chore: remove AWS deployment #603

merged 4 commits into from
Jun 9, 2022
+34 −482

Conversation

thekaveman
Copy link
Member

We've migrated the app to Azure hosting. This PR removes the AWS deployment bits and updates the docs to reflect the new hosting situation.

Once this PR is merged, the 3 GitHub environments dev, test, and prod can be deleted as their secrets are no longer needed.

@thekaveman thekaveman added this to the Hosting migration milestone May 19, 2022
@github-actions github-actions bot added documentation [auto] Improvements or additions to documentation deployment-dev [auto] Changes that will trigger a deploy if merged to dev actions Related to GitHub Actions workflows labels May 19, 2022
@machikoyasuda machikoyasuda mentioned this pull request May 19, 2022
Merged
5 tasks
This was referenced May 20, 2022
Closed
Closed
@thekaveman
Copy link
Member Author

Incoming rebase to clean up conflicts.

@afeld afeld added the infrastructure Terraform, Azure, etc. label Jun 2, 2022
@thekaveman
Copy link
Member Author

Blocked while we fully configure the dev slot as part of #615

@thekaveman thekaveman self-assigned this Jun 6, 2022
@thekaveman thekaveman marked this pull request as ready for review June 8, 2022 22:14
@thekaveman thekaveman requested a review from a team as a code owner June 8, 2022 22:14
@thekaveman
Copy link
Member Author

Ready for review now that the dev slot is fully configured

angela-tran
angela-tran reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Do we want to remove the parts of our docs that talk about AWS environment variables?

@thekaveman thekaveman requested a review from angela-tran June 8, 2022 23:54
@machikoyasuda machikoyasuda self-requested a review June 9, 2022 00:25
machikoyasuda
machikoyasuda approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊🎊🎊

@thekaveman thekaveman merged commit 9f8e809 into dev Jun 9, 2022
@thekaveman thekaveman deleted the chore/remove-aws branch June 9, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@angela-tran angela-tran Awaiting requested review from angela-tran

Assignees

@thekaveman thekaveman

Labels
actions Related to GitHub Actions workflows deployment-dev [auto] Changes that will trigger a deploy if merged to dev documentation [auto] Improvements or additions to documentation infrastructure Terraform, Azure, etc.
Projects
Digital Services
Archived in project
Milestone
Hosting migration
Development

Successfully merging this pull request may close these issues.
4 participants
@thekaveman @machikoyasuda @angela-tran @afeld